[PATCH] D38055: Tighten the invariants around LoopBase::invalidate
Stephan Bergmann via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 20 23:52:18 PDT 2017
sberg added inline comments.
================
Comment at: llvm/trunk/include/llvm/Transforms/Scalar/LoopPassManager.h:170
+ assert(&L == CurrentL ||
+ CurrentL->contains(&L) && "Cannot delete a loop outside of the "
"subloop tree currently being processed.");
----------------
sanjoy wrote:
> sberg wrote:
> > there's parentheses missing around the || here, right?
> Since the string evaluates to true, this shouldn't matter -- "(A || B) && True" == "(A || B)" == "A || (B && True)".
>
> Is this causing a warning on some compiler? If so, let me know and I'll fix it (or feel free to directly commit a fix yourself).
> Since the string evaluates to true, this shouldn't matter -- "(A || B) && True" == "(A || B)" == "A || (B && True)".
Sure, but caused -Wparentheses with GCC. Anyway, found fixed meanwhile with r313780.
Repository:
rL LLVM
https://reviews.llvm.org/D38055
More information about the llvm-commits
mailing list