[PATCH] D37631: [libFuzzer] Support using libc++

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

Seems LLVM_ENABLE_LIBCXX is not helpful here.

In https://reviews.llvm.org/D37631#876567, @phosek wrote:

> In https://reviews.llvm.org/D37631#871554, @kcc wrote:
>
> > I would rather require libc++ for libFuzzer to build. Isn't it simpler?
>
>
> There still the case when you're building compiler-rt without having libc++ around in which case you need to fallback onto whatever C++ library is available is on host. Using libc++ whenever the source is available and we're building with Clang, independently of other options, would be fine with me.


I am not sure that I understand your reply.

I think Kostya suggests to remove COMPILER_RT_ENABLE_LIBCXX and go with just:

  if(COMPILER_RT_HAS_LIBCXX_SOURCES)
    use libc++
  else
    whatever is on the host
  endif

Why is this bad?


Repository:
  rL LLVM

https://reviews.llvm.org/D37631