[llvm] r313848 - [X86] Replace a condition that can never be true with an assert.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 17:18:48 PDT 2017


Author: ctopper
Date: Wed Sep 20 17:18:48 2017
New Revision: 313848

URL: http://llvm.org/viewvc/llvm-project?rev=313848&view=rev
Log:
[X86] Replace a condition that can never be true with an assert.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=313848&r1=313847&r2=313848&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Wed Sep 20 17:18:48 2017
@@ -17673,8 +17673,8 @@ SDValue X86TargetLowering::LowerSELECT(S
       if (Subtarget.hasAVX512()) {
         SDValue Cmp = DAG.getNode(X86ISD::FSETCCM, DL, MVT::v1i1, CondOp0,
                                   CondOp1, DAG.getConstant(SSECC, DL, MVT::i8));
-        return DAG.getNode(VT.isVector() ? X86ISD::SELECT : X86ISD::SELECTS,
-                           DL, VT, Cmp, Op1, Op2);
+        assert(!VT.isVector() && "Not a scalar type?");
+        return DAG.getNode(X86ISD::SELECTS, DL, VT, Cmp, Op1, Op2);
       }
 
       SDValue Cmp = DAG.getNode(X86ISD::FSETCC, DL, VT, CondOp0, CondOp1,




More information about the llvm-commits mailing list