[PATCH] D38019: [asan] Fix nested error detection

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 15:06:46 PDT 2017


eugenis added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_report.cc:127
     halt_on_error_ = fatal || flags()->halt_on_error;
-
-    if (lock_.TryLock()) {
-      StartReporting();
-      return;
-    }
-
-    // ASan found two bugs in different threads simultaneously.
-
     u32 current_tid = GetCurrentTidOrInvalid();
 
----------------
What if GetCurrentTidOrInvalid return kInvalidTid? We will start reporting w/o claiming reporting_thread_tid_. Use a different default value?


https://reviews.llvm.org/D38019





More information about the llvm-commits mailing list