[PATCH] D37631: [libFuzzer] Support using libc++

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

In https://reviews.llvm.org/D37631#876077, @phosek wrote:

> In https://reviews.llvm.org/D37631#874773, @vitalybuka wrote:
>
> > Can we just rely on LLVM_ENABLE_LIBCXX instead of introducing COMPILER_RT_ENABLE_LIBCXX?
>
>
> Those fulfill different purpose, `LLVM_ENABLE_LIBCXX` enables building LLVM itself against libc++ (i.e. it passes `-stdlib=libc++` to the host compiler), but it doesn't necessarily mean that the libc++ source is available. I think we should just rely on `COMPILER_RT_HAS_LIBCXX_SOURCES`, i.e. use libc++ anytime its sources are available (and we're building with Clang).


After thinking about it a bit more, I think `LLVM_ENABLE_LIBCXX` is fine for this purpose. The only question is whether you want to have separate toggle, e.g. for testing? Maybe we could keep the separate option but set `LLVM_ENABLE_LIBCXX` as its default value?


Repository:
  rL LLVM

https://reviews.llvm.org/D37631