[PATCH] D37971: [dwarfdump] Add verbose output for .debug-line section

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: test/DebugInfo/MIR/X86/empty-inline.mir:7
 # CHECK: DW_TAG_subprogram
-# CHECK:	DW_AT_low_pc [DW_FORM_addr]	(0x0000000000000000)
+# CHECK:	DW_AT_low_pc {{.*}}(0x0000000000000000)
 # CHECK-NOT: DW_TAG
----------------
dblaikie wrote:
> I don't think the {{.*}} is needed? Maybe - not sure how whitespace-ignorant FileCheck is by default.
AFAIK only leading and trailing whitespace is ignored. An additional benefit is that most of the lines won't have to be changed if we ever want to make the test verbose again. 


================
Comment at: test/MC/ARM/dwarf-asm-multiple-sections.s:55-58
+// DWARF-DL:      0x0000000000000000     17      0      1   0   0  is_stmt
+// DWARF-DL-NEXT: 0x0000000000000004     17      0      1   0   0  is_stmt end_sequence
+// DWARF-DL-NEXT: 0x0000000000000000     21      0      1   0   0  is_stmt
+// DWARF-DL-NEXT: 0x0000000000000004     21      0      1   0   0  is_stmt end_sequence
----------------
dblaikie wrote:
> Why did these line numbers change?
That's because added the 3 run lines at the top of the file, before the code. 


https://reviews.llvm.org/D37971