[llvm] r313748 - Revert r313746 "[yaml2obj] - Don't crash on invalid document."

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 03:24:37 PDT 2017


Author: grimar
Date: Wed Sep 20 03:24:37 2017
New Revision: 313748

URL: http://llvm.org/viewvc/llvm-project?rev=313748&view=rev
Log:
Revert r313746 "[yaml2obj] - Don't crash on invalid document."

It broke BB:
http://lab.llvm.org:8011/builders/llvm-hexagon-elf/builds/9781

Removed:
    llvm/trunk/test/Object/yaml2obj-invalid.yaml
Modified:
    llvm/trunk/include/llvm/Support/YAMLTraits.h

Modified: llvm/trunk/include/llvm/Support/YAMLTraits.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/YAMLTraits.h?rev=313748&r1=313747&r2=313748&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/YAMLTraits.h (original)
+++ llvm/trunk/include/llvm/Support/YAMLTraits.h Wed Sep 20 03:24:37 2017
@@ -1418,8 +1418,8 @@ inline typename std::enable_if<has_Mappi
                                Input &>::type
 operator>>(Input &yin, T &docMap) {
   EmptyContext Ctx;
-  if (yin.setCurrentDocument())
-    yamlize(yin, docMap, true, Ctx);
+  yin.setCurrentDocument();
+  yamlize(yin, docMap, true, Ctx);
   return yin;
 }
 

Removed: llvm/trunk/test/Object/yaml2obj-invalid.yaml
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/yaml2obj-invalid.yaml?rev=313747&view=auto
==============================================================================
--- llvm/trunk/test/Object/yaml2obj-invalid.yaml (original)
+++ llvm/trunk/test/Object/yaml2obj-invalid.yaml (removed)
@@ -1,2 +0,0 @@
-# RUN: not yaml2obj %s 2>&1 | FileCheck %s
-# CHECK: Unknown document type!




More information about the llvm-commits mailing list