[PATCH] D37760: [AMDGPU] do not generate .AMDGPU.config for amdpal os type

Tim Renouf via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 02:22:47 PDT 2017


tpr added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:254
   MCContext &Context = getObjFileLowering().getContext();
-  if (!STM.isAmdHsaOS()) {
+  if (!STM.isAmdHsaOS() && !STM.isAmdPalOS()) {
     MCSectionELF *ConfigSection =
----------------
arsenm wrote:
> Probably should make this a positive check on is mesa (although that might be broken because I'm not sure mesa graphics ever fully switched to explicitly setting the triple)
Yeah, I don't think that happens anywhere else for mesa, so I assume mesa doesn't set the os type in the triple. So can I leave this as it is?


https://reviews.llvm.org/D37760





More information about the llvm-commits mailing list