[PATCH] D38055: Tighten the invariants around LoopBase::invalidate

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added inline comments.


================
Comment at: include/llvm/Analysis/LoopInfo.h:86
+  void invalidate() {
+    IsInvalid = true;
+    SubLoops.clear();
----------------
chandlerc wrote:
> This seems redundant if you set `ParentLoop` to null? I guess not for top-level loops.
> 
> But it is also redundant with an empty `Blocks` vector. Anyways, I'd try to remove this at some point.
Yes, this is equivalent to `Blocks.empty()`.  Do you want me to roll that into this change?  Or is a separate change fine?


https://reviews.llvm.org/D38055