[PATCH] D37421: [XRay] [test-suite] Add LNT support to retref-bench benchmarks.

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

In https://reviews.llvm.org/D37421#874416, @MatzeB wrote:

> First: This looks ok and can be committed as is if you want.
>
> However IMO using the LNTBased system here is not the best choice, I'd rather try writing a `litsupport` plugin. LNTBased is little used and IMO less flexible than the cmake+lit plugin approach.


I agree, having this in litsupport seems better (and also solves the duplication/symlink problem). I imagine that the plugin could append a function to metric_collectors that reads the CSV and reports the associated timing data. @MatzeB, is there documentation on the litsupport plugin interface anywhere? (if all we have is what's in the README.md, we should write some more).


https://reviews.llvm.org/D37421