[PATCH] D35396: [lit] Remove %T

[Peter Wu via Phabricator via llvm-commits]

Lekensteyn added a comment.

While at it, could the documentation also be clarified whether `%t` refers to a prefix (or note that it is created in a subdirectory such that one can know for sure that it is cleaned up)? A lot of tests use something like `%clang -o %t.o`.

As for whether `mkdir -p` can be used or not, based on a look in `utils/lit/`, there does not seem to be a special case for that. Very few builtins (`export`, `echo`, `cd`) are handled. Perhaps it would be worth adding more builtins and/or document whether it is safe to use those? Looking at a Windows builder (http://lab.llvm.org:8011/buildslaves/windows7-buildbot) though, the `Profile/gcc-flag-compatibility.c` test does get executed properly (it uses `rm -rf` and `mkdir -p ../..`).

@rnk Are the GnuWin32 tools just needed for the test suite or is it also needed for the build process? (Linux user here, no idea how LLVM is usually developed on Windows)


https://reviews.llvm.org/D35396