[PATCH] D37996: [LoopInfo] Make LoopBase and Loop destructors non-public

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 16:24:48 PDT 2017


sanjoy added inline comments.


================
Comment at: lib/Analysis/LoopInfo.cpp:625
 
-void LoopInfo::markAsRemoved(Loop *Unloop) {
-  assert(!Unloop->isInvalid() && "Loop has already been removed");
+void LoopInfo::markAsErased(Loop *Unloop) {
+  assert(!Unloop->isInvalid() && "Loop has already been erased!");
----------------
chandlerc wrote:
> This should really be `erase` rather than `markAsErased`... But happy for that to be a later change.
I'll do that renaming once the bump ptr allocator change has landed.


Repository:
  rL LLVM

https://reviews.llvm.org/D37996





More information about the llvm-commits mailing list