[PATCH] D38010: lit.py: Allow configs and local configs to have a setup_script entry

Jordan Rose via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 15:52:43 PDT 2017


jordan_rose added a comment.

> You mentioned you want to make this work with the multiprocessing pool. That worries me a little bit because different processes are going to be using the same shared output dir (which isn't created up front by the infrastructure), if I understand correctly. Like if you have A and A/B and A/C, then we will run the setup script 3 times in parallel all using the same shared output folder. Is this going to be a source of flakiness?

Ah, that's not what happens. In the scenario you described, the script gets run for A/Output/Shared, A/B/Output/Shared, and A/C/Output/Shared. There's no feature (currently) for having a common `%shared_output` across multiple test directories because I didn't want to deal with synchronization. (Something like that would mean bringing back `%T`, though perhaps under a different name.)


https://reviews.llvm.org/D38010





More information about the llvm-commits mailing list