[PATCH] D37957: [TableGen] Some simple optimizations to TableGen execution time

[Zachary Turner via Phabricator via llvm-commits]

zturner updated this revision to Diff 115886.
zturner added a comment.

Rebased on top of changes.

Original baseline (before any performance regression): 11s
After regression: 38s
+Krzysztof's improvements: 26s
+These additional optimizations: 16s

I think this is close enough to the original baseline that it's within the realm of being tolerable.  I do get an assertion failure when I run with my patch in debug build, because it's trying to insert an empty `StringRef` into a `StringSet`, which is not allowed.  Can you apply this patch Krzysztof and see if you can figure out what the right thing to do is with the empty `StringRef`?


https://reviews.llvm.org/D37957

Files:
  llvm/include/llvm/ADT/DenseSet.h
  llvm/include/llvm/CodeGen/MachineValueType.h
  llvm/utils/TableGen/CodeGenDAGPatterns.cpp
  llvm/utils/TableGen/CodeGenDAGPatterns.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37957.115886.patch
Type: text/x-patch
Size: 22341 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170919/33cea855/attachment.bin>