[PATCH] D38010: lit.py: Allow configs and local configs to have a setup_script entry

[Jordan Rose via Phabricator via llvm-commits]

jordan_rose added inline comments.


================
Comment at: utils/lit/tests/Inputs/setup-script/subdir-custom/lit.local.cfg:1
+config.setup_script = 'Inputs/custom.sh'
----------------
zturner wrote:
> zturner wrote:
> > Can you make this not be a shell script?  This is essentially saying "This test doesn't work on Windows" when there's no particular reason why it shouldn't
> Actually I take that back.  This //can't// be a shell script, because it's saying "this //feature// doesn't work on Windows".  So I think this has to be a Python script, and you just `execfile` it.  If you want to run a shell script, you can still do that by having a Python script which runs a shell script.  But the lit infrastructure should only deal with Python scripts.
I'm happy to make the tests use Python—good point—but I don't see why the feature wouldn't work on Windows. Windows can already run Python scripts from the command line, right?


Repository:
  rL LLVM

https://reviews.llvm.org/D38010