[PATCH] D37877: Update getMergedLocation to check the instruction type and merge properly.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Looks mostly good now. One more inline comment.



================
Comment at: include/llvm/IR/Instruction.h:391
+  ///     applications, thus the N-way merging should be in code path.
+  void applyMergedLocation(const DILocation *LocA, const DILocation *LocB);
+
----------------
Should we document what happens to the debug location already attached to `this`? Or - looking at the use-cases - should it assert that the debugloc is empty?


https://reviews.llvm.org/D37877