[PATCH] D38001: [X86] Don't select anyext GR32->GR64 to SUBREG_TO_REG. Use INSERT_SUBREG instead.

David Kreitzer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 05:25:07 PDT 2017

Previous message: [PATCH] D38001: [X86] Don't select any extend of anyext GR32->GR64 to SUBREG_TO_REG. Use INSERT_SUBREG instead.
Next message: [PATCH] D38001: [X86] Don't select anyext GR32->GR64 to SUBREG_TO_REG. Use INSERT_SUBREG instead.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

DavidKreitzer added a comment.

This change seems obviously correct. The diffs in the tests all look like tweaks in the register allocation behavior and aren't testing the behavior you are fixing. Is it possible to write a test that miscompiles due to the existing bug?


https://reviews.llvm.org/D38001

Previous message: [PATCH] D38001: [X86] Don't select any extend of anyext GR32->GR64 to SUBREG_TO_REG. Use INSERT_SUBREG instead.
Next message: [PATCH] D38001: [X86] Don't select anyext GR32->GR64 to SUBREG_TO_REG. Use INSERT_SUBREG instead.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list