[PATCH] D38008: [llvm-objcopy] Refactor code to include initialize method

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Just to point out, there's no diff context here! Aside from that, the overall change here looks good. I'm slightly surprised to see the SectionTable being copied everywhere, as I'd expect there to only be one, but I guess it doesn't matter since it's just a wrapper around a reference to an array of pointers.



================
Comment at: tools/llvm-objcopy/Object.h:36
+  T *getSectionOfType(uint16_t Index, llvm::Twine ErrMsg,
+                      llvm::Twine CastErrMsg);
+};
----------------
See my comment in D36560 regarding the argument names here.


Repository:
  rL LLVM

https://reviews.llvm.org/D38008