[PATCH] D38022: [X86] Convert X86ISD::SELECT to ISD::VSELECT just before instruction selection to avoid duplicate patterns

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 18 23:56:51 PDT 2017


craig.topper added a comment.

Here's the comment from getVectorMaskingNode

  case X86ISD::VTRUNC:
  case X86ISD::VTRUNCS:
  case X86ISD::VTRUNCUS:
  case X86ISD::CVTPS2PH:
    // We can't use ISD::VSELECT here because it is not always "Legal"
    // for the destination type. For example vpmovqb require only AVX512
    // and vselect that can operate on byte element type require BWI
    OpcodeSelect = X86ISD::SELECT;
    break;
  }


https://reviews.llvm.org/D38022





More information about the llvm-commits mailing list