[PATCH] D37421: [XRay] [test-suite] Add LNT support to retref-bench benchmarks.

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

First: This looks ok and can be committed as is if you want.

However IMO using the LNTBased system here is not the best choice, I'd rather try writing a `litsupport` plugin. LNTBased is little used and IMO less flexible than the cmake+lit plugin approach.



================
Comment at: LNTBased/MicroBenchmarks/XRay/CMakeLists.txt:1-13
+cmake_minimum_required(VERSION 3.7)
+
+include(CheckCXXCompilerFlag)
+check_cxx_compiler_flag(-fxray-instrument COMPILER_HAS_FXRAY_INSTRUMENT)
+
+if("${ARCH}" STREQUAL "x86_64" AND "${COMPILER_HAS_FXRAY_INSTRUMENT}")
+  add_subdirectory(benchmark-1.2.0)
----------------
I don't see why you need a separate CMakeLists.txt here?


https://reviews.llvm.org/D37421