[PATCH] D37877: Update getMergedLocation to check the instruction type and merge properly.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 18 13:52:28 PDT 2017


aprantl added a comment.

I think this works for me.



================
Comment at: include/llvm/IR/DebugInfoMetadata.h:1428
+  ///      call can be treated the same as other instructions.
+  /// applyMergedLocation: This should be used by Instruction. It will have
+  ///      special handling for CallInst as we need to traverse the inline
----------------
`it has` ?


================
Comment at: include/llvm/IR/DebugInfoMetadata.h:1446
   }
 
+  static void applyMergedLocation(
----------------
Please add something like `/// See documentation of \p getMergedLocation.`


https://reviews.llvm.org/D37877





More information about the llvm-commits mailing list