[PATCH] D37990: [scudo] Additional modifications for Android tests support

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad created this revision.
Herald added subscribers: kubamracek, srhines.

With the recent move of `android_commands` to `sanitizer_common`, some things
have to be updated with regard to Scudo on Android.

Notably:

- `config.android` is dealt with in the common code
- `config.compile_wrapper` can be prepended to allow for the use of the android commands
- `SCUDO_OPTIONS` must be passed with the environment when running a test
- `preinit.cpp` fails with some API levels, not sure why, I will have to dig into this later.

Note that `check-scudo` is not enabled yet in the bots. It's all local testing
for now until everything looks good.


https://reviews.llvm.org/D37990

Files:
  test/sanitizer_common/android_commands/android_run.py
  test/scudo/lit.cfg
  test/scudo/lit.site.cfg.in
  test/scudo/preinit.cpp


Index: test/scudo/preinit.cpp
===================================================================
--- test/scudo/preinit.cpp
+++ test/scudo/preinit.cpp
@@ -4,6 +4,10 @@
 // Verifies that calling malloc in a preinit_array function succeeds, and that
 // the resulting pointer can be freed at program termination.
 
+// Succeeds on some API levels, fails on some others.
+// TODO(kostyak): investigate the issue.
+// XFAIL: android
+
 #include <assert.h>
 #include <stdlib.h>
 #include <string.h>
Index: test/scudo/lit.site.cfg.in
===================================================================
--- test/scudo/lit.site.cfg.in
+++ test/scudo/lit.site.cfg.in
@@ -3,7 +3,6 @@
 config.name_suffix = "@SCUDO_TEST_CONFIG_SUFFIX@"
 config.target_arch = "@SCUDO_TEST_TARGET_ARCH@"
 config.target_cflags = "@SCUDO_TEST_TARGET_CFLAGS@"
-config.android = "@ANDROID@"
 
 # Load common config for all compiler-rt lit tests.
 lit_config.load_config(config, "@COMPILER_RT_BINARY_DIR@/test/lit.common.configured")
Index: test/scudo/lit.cfg
===================================================================
--- test/scudo/lit.cfg
+++ test/scudo/lit.cfg
@@ -32,7 +32,7 @@
   c_flags += ["-lrt"]
 
 def build_invocation(compile_flags):                                            
-  return " " + " ".join([config.clang] + compile_flags) + " "                   
+  return " " + " ".join([config.compile_wrapper, config.clang] + compile_flags) + " "                   
 
 # Add clang substitutions.
 config.substitutions.append(("%clang_scudo ",
Index: test/sanitizer_common/android_commands/android_run.py
===================================================================
--- test/sanitizer_common/android_commands/android_run.py
+++ test/sanitizer_common/android_commands/android_run.py
@@ -13,7 +13,7 @@
     # Android linker ignores RPATH. Set LD_LIBRARY_PATH to Output dir.
     args.append('LD_LIBRARY_PATH=%s' % (ANDROID_TMPDIR,))
     for (key, value) in os.environ.items():
-        if key in ['ASAN_OPTIONS', 'ASAN_ACTIVATION_OPTIONS']:
+        if key in ['ASAN_OPTIONS', 'ASAN_ACTIVATION_OPTIONS', 'SCUDO_OPTIONS']:
             args.append('%s="%s"' % (key, value))
     return ' '.join(args)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37990.115699.patch
Type: text/x-patch
Size: 2194 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170918/92e7a973/attachment.bin>