[PATCH] D37907: [scudo] Android build support

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: test/scudo/CMakeLists.txt:20
+    if (${arch} STREQUAL "i386")
+      set(SCUDO_TEST_TARGET_ARCH i686-android)
+    else()
----------------
Why do you need this? 
I don't see you use it it tests or cfg files.
In tests you can achieve the same  with:
// XFAIL: android && i386-target-arch


================
Comment at: test/scudo/lit.site.cfg.in:6
 config.target_cflags = "@SCUDO_TEST_TARGET_CFLAGS@"
+config.android = "@ANDROID@"
 
----------------
You don't need this. Its already in the compiler-rt/test/lit.common.configured.in


https://reviews.llvm.org/D37907