[PATCH] D37971: [dwarfdump] Add verbose output for .debug-line section

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 18 08:44:32 PDT 2017


JDevlieghere updated this revision to Diff 115662.
JDevlieghere added a comment.
Herald added subscribers: eraman, javed.absar, sdardis, mehdi_amini.

In https://reviews.llvm.org/D37971#873777, @aprantl wrote:

> Doing this during parsing doesn't seem too intrusive and looks like it is the right trade-off.
>  Do you have a test case, too?


Jup, I put up the code before/while fixing the tests. I've added a `verbose.test` to check the printing of the opcodes. The existing tests that use verbose mode essentially verify that the resulting rows are still identical. As a verification I also ran a diff against Darwin's dwarfdump and the printed opcodes are identical.


https://reviews.llvm.org/D37971

Files:
  include/llvm/DebugInfo/DWARF/DWARFDebugLine.h
  lib/DebugInfo/DWARF/DWARFContext.cpp
  lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  test/DebugInfo/MIR/X86/empty-inline.mir
  test/DebugInfo/Mips/delay-slot.ll
  test/MC/ARM/dwarf-asm-multiple-sections-dwarf-2.s
  test/MC/ARM/dwarf-asm-multiple-sections.s
  test/MC/ARM/dwarf-asm-nonstandard-section.s
  test/MC/ARM/dwarf-asm-single-section.s
  test/MC/MachO/gen-dwarf.s
  test/tools/dsymutil/X86/basic-linking-x86.test
  test/tools/dsymutil/X86/basic-lto-dw4-linking-x86.test
  test/tools/dsymutil/X86/basic-lto-linking-x86.test
  test/tools/llvm-dwarfdump/X86/brief.s
  test/tools/llvm-dwarfdump/X86/verbose.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37971.115662.patch
Type: text/x-patch
Size: 38869 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170918/e70f0169/attachment-0001.bin>


More information about the llvm-commits mailing list