[PATCH] D35987: [ELF] - Introduce std::vector<InputFile *> global arrays.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 18 08:05:42 PDT 2017


grimar added inline comments.


================
Comment at: ELF/SymbolTable.cpp:595
+  for (InputFile *F : SharedFiles) {
+    SharedFile<ELFT> *File = cast<SharedFile<ELFT>>(F);
     for (StringRef U : File->getUndefinedSymbols()) {
----------------
ruiu wrote:
> Remove this temporary variable.
Done.


================
Comment at: ELF/Writer.cpp:118
 
 template <class ELFT> static bool needsInterpSection() {
+  return !SharedFiles.empty() && !Config->DynamicLinker.empty() &&
----------------
ruiu wrote:
> Remove template.
Done.


https://reviews.llvm.org/D35987





More information about the llvm-commits mailing list