[PATCH] D34689: [LLD][ELF] Pre-create ThunkSections at Target specific intervals

[Peter Smith via Phabricator via llvm-commits]

peter.smith updated this revision to Diff 115632.
peter.smith added a comment.

Thanks for pointing the typos in the comment out, I've uploaded a new patch to fix them.

At the moment I've got 5 remaining reviews in the RangeThunks series. It would be great if I could get some feedback on how to progress these towards either approval or rejection as they have been present in much the same form (modulo refactoring) for several Months now. I'm wondering if there is anything more that I could or should be doing beyond replying to comments. Many thanks to everyone for all the comments received so far and I do appreciate that it is difficult to review a large Target specific change. I'd like to make it any easier to review, but I need a bit more feedback on the blocking areas as I've probably been staring at this too long.

The outstanding reviews can be committed in sequence without regressing from the previous patch.

- https://reviews.llvm.org/D37743 Record created ThunkSections in InputSectionDescription (Refactoring only)
- https://reviews.llvm.org/D34689 Pre-create ThunkSections at Target specific intervals
- https://reviews.llvm.org/D34691 Introduce range extension thunks for ARM
- https://reviews.llvm.org/D34692 Add support for multiple passes to createThunks
- https://reviews.llvm.org/D35413 Add DefinedInThunk to SymbolBody to remove need for hash lookup (Refactoring only)


https://reviews.llvm.org/D34689

Files:
  ELF/Arch/ARM.cpp
  ELF/Relocations.cpp
  ELF/Relocations.h
  ELF/SyntheticSections.cpp
  ELF/Target.h
  test/ELF/arm-thumb-thunk-symbols.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34689.115632.patch
Type: text/x-patch
Size: 9297 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170918/055c75d2/attachment.bin>