[PATCH] D37256: [Nios2] adding subtarget, basic infrastructure for frame, instructions and registers

[Andrei via Phabricator via llvm-commits]

AndreiGrischenko added a comment.

Hi,

I've prepared another two patches, that include DAG selector, assembly printing and all NiosII instructions. But it makes sense to upload them for review after I commit the current with Subtarget. Could you please take a look?

Thanks,
Andrie.



================
Comment at: llvm/lib/Target/Nios2/Nios2RegisterInfo.cpp:35
+Nios2RegisterInfo::getCalleeSavedRegs(const MachineFunction *MF) const {
+  return NULL;
+}
----------------
craig.topper wrote:
> Use nullptr instead of NULL
OK, thanks.


================
Comment at: llvm/lib/Target/Nios2/Nios2Subtarget.cpp:45
+  if (TargetTriple.getArch() == Triple::nios2) {
+    if (CPU.empty() || CPU == "generic") {
+      CPU = "nios2r1";
----------------
craig.topper wrote:
> This doesn't look like what other targets do. I don't see any other target looking for "help".
Yes, thanks. I simplified this.


https://reviews.llvm.org/D37256