[PATCH] D32840: [XRay] convert FDR arg1 log entries

[Martin Pelikán via Phabricator via llvm-commits]

pelikan added a comment.

I will wait for the other diff to go in then.  In the meantime I can sort out my new system's toolchain issues.



================
Comment at: include/llvm/XRay/YAMLXRayRecord.h:89
+template <> struct SequenceTraits<std::vector<uint64_t>> {
+  static constexpr bool flow = true;
+  static size_t size(IO &IO, std::vector<uint64_t> &V) { return V.size(); }
----------------
dberris wrote:
> What is this meant to do? Is it meant to force text wrapping? If so, please don't do that (it messes with the tests and the settings that can be defined on the YAML stream instead).
It's meant to *remove* text wrapping.  Since we only really support one argument in the list, we want it to look like "[ 1 ]", not like "[\n\t1,\n]\n" or whatever it thinks is in order.  This way each log entry will only occupy one line, as they should (both for readability and parsability).


https://reviews.llvm.org/D32840