[PATCH] D32840: [XRay] convert FDR arg1 log entries

[Martin Pelikán via Phabricator via llvm-commits]

pelikan added inline comments.


================
Comment at: include/llvm/XRay/XRayRecord.h:56
 /// of loading).
-enum class RecordTypes { ENTER, EXIT };
+enum class RecordTypes { ENTER, EXIT, ENTER_ARG };
 
----------------
kpw wrote:
> kpw wrote:
> > I just realized that doing this definition would be unfortunate, because we'll drift out of sync with XRayEntryType defined in compiler-rt/include/xray/xray_interface.h
> > 
> >   enum XRayEntryType {
> >     ENTRY = 0,
> >     EXIT = 1,
> >     TAIL = 2,
> >     LOG_ARGS_ENTRY = 3,
> >     CUSTOM_EVENT = 4,
> >   };
> > 
> > Could you either define TAIL or assign 3 to ENTER_ARG. Defining TAIL is likely better done in a separate patch that updates the llvm-xray subcommands to handle it.
> > 
> Ugh. These are also defined in AsmPrinter::SledKind.
Ugh indeed.  I was under the impression this should be ignored as compiler-rt is "a different project".  I've added the "= 3" there.


================
Comment at: lib/XRay/Trace.cpp:228
   // We can encounter a CustomEventMarker anywhere in the log, so we can handle
   // it regardless of the expectation. However, we do se the expectation to read
   // a set number of fixed bytes, as described in the metadata.
----------------
kpw wrote:
> we do se -> we do use?
Resolved in a different diff.


https://reviews.llvm.org/D32840