[PATCH] D37736: [ELF] - Do not spread specific flags when emiting output sections.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 22:23:29 PDT 2017


grimar added a comment.

In https://reviews.llvm.org/D37736#872819, @ruiu wrote:

> This is not in a right direction because of the same reason as I wrote before. There are basic rules here:
>
> - output section flags are essentially the same as input sections' flags, and
> - to make it possible, drop an unwanted flag after we read it.


That was clear from your first comment and I did not update the patch after that yet. My comment above actually describing the
problem I faced when tried to drop the flag. Patch is still in "update planned" status.

> I do not have time to point out all the location you need to update to satisfy the above rules, but can you please try to drop SHF_LINK_ORDER earlier? I'd take more time for each patch.


https://reviews.llvm.org/D37736





More information about the llvm-commits mailing list