[PATCH] D37775: Add a verifier test to check the access on both sides of COPY are the same

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 15:04:07 PDT 2017


aditya_nandakumar added a comment.

Also, there are various tests that need to be updated by the various backends, and I can only land once those are updated. I haven't had time to update all the backends.



================
Comment at: lib/CodeGen/MachineVerifier.cpp:957
+                             ? DstTy.getSizeInBits()
+                             : TRI->getRegSizeInBits(DstOp.getReg(), *MRI);
+      assert(SrcSize && "Expecting size here");
----------------
qcolombet wrote:
> Seeing this pattern being actually the implementation of RegisterBankInfo::getSizeInBits, I would suggest to move the whole RegisterBankInfo::getSizeInBits directly in TargetRegisterInfo.
I thought TargetRegisterInfo doesn't have LLT headers pulled in (but looks like it is getting transitively pulled in). I can pretty much move the implementation of RegisterBankInfo::getSizeInBits into TargetRegisterInfo.


https://reviews.llvm.org/D37775





More information about the llvm-commits mailing list