[PATCH] D37920: Resubmit (Fixed) "[lit] Force site configs to be run before source tree configs"

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

In https://reviews.llvm.org/D37920#872453, @rnk wrote:

> This is problematic because people already complain about how compiler-rt depends on the LLVM source tree for gtest sources: https://bugs.llvm.org/show_bug.cgi?id=33693


I don't think this is making things any worse.  Even before this patch, the compiler-rt test suite need `lit.py` to run which is, as you guessed, in the source tree.  Indeed, the lit command it generates points directly into the source tree.

That aside, how important is this use case?  It doesn't appear to be currently supported given that a `lit.py` already needs to exist, and if only one person is complaining, then I think the complexity reduction from the new lit workflow outweighs one person's pain (granted, I'm biased, but still)


https://reviews.llvm.org/D37920