[PATCH] D37876: [WebAssembly] MC: Create wasm data segments based on MCSections

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

Added support for explicit custom section names, and added new test



================
Comment at: lib/MC/WasmObjectWriter.cpp:515
+      if (Align->getValueSize() != 1)
+        report_fatal_error("only byte values supported for alignment");
+      // If nops are requested, use zeros, as this is the data section.
----------------
dschuff wrote:
> Does this mean we don't support the .p2align directive?
> If so, we should have a TODO to fix it. Or do we just expect it to get converted and we should never see this (in other words, can it be an assert instead)?
I'm not sure why this is here but we haven't been seeing this show up in testing yet.   I'm only moving this code.   I'd rather not  also change it in this CL.


https://reviews.llvm.org/D37876