[PATCH] D37907: [scudo] Android build support

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 10:00:27 PDT 2017


cryptoad created this revision.
Herald added subscribers: mgorny, srhines.

Mark Android as supported in the cmake configuration for Scudo.

Scudo is not added yet in the Android build bots, but code builds and tests
pass locally. It is for a later CL. I also checked that Scudo builds as part
of the Android toolchain.

A few modifications had to be made:

- Android defaults to `abort_on_error=1`, which doesn't work well with the current tests. So change the default way to pass `SCUDO_OPTIONS` to the tests to account for this, setting it to 0 by default;
- Disable the `valloc.cpp` & `random_shuffle.cpp` tests on Android;
- There is a bit of gymnatic to be done with the `SCUDO_TEST_TARGET_ARCH` string, due to android using the `-android` suffix, and `i686` instead of `i386`;
- Android doesn't need `-lrt`.


https://reviews.llvm.org/D37907

Files:
  cmake/config-ix.cmake
  test/scudo/CMakeLists.txt
  test/scudo/lit.cfg
  test/scudo/lit.site.cfg.in
  test/scudo/memalign.cpp
  test/scudo/mismatch.cpp
  test/scudo/options.cpp
  test/scudo/overflow.cpp
  test/scudo/quarantine.cpp
  test/scudo/random_shuffle.cpp
  test/scudo/sized-delete.cpp
  test/scudo/sizes.cpp
  test/scudo/threads.cpp
  test/scudo/valloc.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37907.115417.patch
Type: text/x-patch
Size: 14014 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170915/5fdc20c3/attachment.bin>


More information about the llvm-commits mailing list