[PATCH] D37837: Keep some relocations with undefined weak symbols

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 09:41:36 PDT 2017


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

createFiles puts all files, including shared ones, in "Files". It is
Symtab->addFile that populates SharedFile<ELFT>::Instances.

We could try to refactor that, but it seems better do that on a followup
patch.

Cheers,
Rafael

> ruiu added a comment.
>
>> Unfortunately it also depends on there being a .so in the link or not,
>>  so it has to be set after the others.
>
> SetConfigs is called after createFiles, and all .so files are added by createFiles, it is safe to initialize the variable in SetConfigs, no?
>
>
> https://reviews.llvm.org/D37837


More information about the llvm-commits mailing list