[PATCH] D37734: [GlobalISel][X86] G_FCONSTANT support.

Igor Breger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 08:57:40 PDT 2017


igorb added inline comments.


================
Comment at: lib/Target/X86/X86InstructionSelector.cpp:1220
+  // Create the load from the constant pool.
+  const ConstantFP *CFP = I.getOperand(1).getFPImm();
+  unsigned CPI = MF.getConstantPool()->getConstantPoolIndex(CFP, Align);
----------------
delena wrote:
> Can PCIBase remain 0? According to the code, you calculate PCIBase for the Large  model, but do not use it.
Yes , in 32bit mode.


https://reviews.llvm.org/D37734





More information about the llvm-commits mailing list