[PATCH] D37880: Fix an out-of-bounds shufflevector index bug

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 15 03:00:35 PDT 2017


RKSimon added inline comments.


================
Comment at: test/CodeGen/ARM/crash-on-pow2-shufflevector.ll:19
+;
+
+%struct.desc = type { i32, [7 x i32] }
----------------
javed.absar wrote:
> Shouldn't this test have some sort of 'CHECK'? 
Make the lit command something like:
```
; RUN: llc < %s -mtriple=armv7--linux-android | FileCheck %s
```
You should then be able to use utils/update_llc_test_checks.py to create the CHECKS


================
Comment at: test/CodeGen/ARM/crash-on-pow2-shufflevector.ll:63
+  ret i32 undef
+}
----------------
You should be able to reduce this test case a lot more, either by hand or with bugpoint


https://reviews.llvm.org/D37880





More information about the llvm-commits mailing list