[PATCH] D35100: [PATCH] Fix missing arguments to getType and getSymbol in Elf_Rel_Impl

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 20:01:32 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL313336: [Object] Fix missing arguments to getType and getSymbol in Elf_Rel_Impl (authored by phosek).

Changed prior to commit:
  https://reviews.llvm.org/D35100?vs=105575&id=115353#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D35100

Files:
  llvm/trunk/include/llvm/Object/ELFTypes.h


Index: llvm/trunk/include/llvm/Object/ELFTypes.h
===================================================================
--- llvm/trunk/include/llvm/Object/ELFTypes.h
+++ llvm/trunk/include/llvm/Object/ELFTypes.h
@@ -406,10 +406,10 @@
     return (unsigned char)(this->getRInfo(isMips64EL) & 0x0ff);
   }
   void setSymbol(uint32_t s, bool IsMips64EL) {
-    setSymbolAndType(s, getType(), IsMips64EL);
+    setSymbolAndType(s, getType(IsMips64EL), IsMips64EL);
   }
   void setType(unsigned char t, bool IsMips64EL) {
-    setSymbolAndType(getSymbol(), t, IsMips64EL);
+    setSymbolAndType(getSymbol(IsMips64EL), t, IsMips64EL);
   }
   void setSymbolAndType(uint32_t s, unsigned char t, bool IsMips64EL) {
     this->setRInfo((s << 8) + t, IsMips64EL);
@@ -459,10 +459,10 @@
     return (uint32_t)(this->getRInfo(isMips64EL) & 0xffffffffL);
   }
   void setSymbol(uint32_t s, bool IsMips64EL) {
-    setSymbolAndType(s, getType(), IsMips64EL);
+    setSymbolAndType(s, getType(IsMips64EL), IsMips64EL);
   }
   void setType(uint32_t t, bool IsMips64EL) {
-    setSymbolAndType(getSymbol(), t, IsMips64EL);
+    setSymbolAndType(getSymbol(IsMips64EL), t, IsMips64EL);
   }
   void setSymbolAndType(uint32_t s, uint32_t t, bool IsMips64EL) {
     this->setRInfo(((uint64_t)s << 32) + (t & 0xffffffffL), IsMips64EL);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35100.115353.patch
Type: text/x-patch
Size: 1313 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170915/f0269907/attachment.bin>


More information about the llvm-commits mailing list