[PATCH] D37884: ubsan: Stop building the DLL version of the runtime library on Windows.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 19:06:29 PDT 2017


pcc created this revision.
Herald added subscribers: mgorny, kubamracek.

As far as I know we never use it.


https://reviews.llvm.org/D37884

Files:
  compiler-rt/lib/ubsan/CMakeLists.txt


Index: compiler-rt/lib/ubsan/CMakeLists.txt
===================================================================
--- compiler-rt/lib/ubsan/CMakeLists.txt
+++ compiler-rt/lib/ubsan/CMakeLists.txt
@@ -153,30 +153,30 @@
       CFLAGS ${UBSAN_CXXFLAGS}
       PARENT_TARGET ubsan)
 
-    add_compiler_rt_runtime(clang_rt.ubsan_standalone
-      SHARED
-      ARCHS ${UBSAN_SUPPORTED_ARCH}
-      OBJECT_LIBS RTSanitizerCommon
-              RTSanitizerCommonLibc
-              RTUbsan
-      CFLAGS ${UBSAN_CFLAGS}
-      LINK_FLAGS ${SANITIZER_COMMON_LINK_FLAGS}
-      LINK_LIBS ${UBSAN_DYNAMIC_LIBS}
-      PARENT_TARGET ubsan)
-
-    add_compiler_rt_runtime(clang_rt.ubsan_standalone_cxx
-      SHARED
-      ARCHS ${UBSAN_SUPPORTED_ARCH}
-      OBJECT_LIBS RTSanitizerCommon
-              RTSanitizerCommonLibc
-              RTUbsan
-              RTUbsan_cxx
-      CFLAGS ${UBSAN_CXXFLAGS}
-      LINK_FLAGS ${SANITIZER_COMMON_LINK_FLAGS}
-      LINK_LIBS ${UBSAN_DYNAMIC_LIBS}
-      PARENT_TARGET ubsan)
-
     if (UNIX)
+      add_compiler_rt_runtime(clang_rt.ubsan_standalone
+        SHARED
+        ARCHS ${UBSAN_SUPPORTED_ARCH}
+        OBJECT_LIBS RTSanitizerCommon
+                RTSanitizerCommonLibc
+                RTUbsan
+        CFLAGS ${UBSAN_CFLAGS}
+        LINK_FLAGS ${SANITIZER_COMMON_LINK_FLAGS}
+        LINK_LIBS ${UBSAN_DYNAMIC_LIBS}
+        PARENT_TARGET ubsan)
+
+      add_compiler_rt_runtime(clang_rt.ubsan_standalone_cxx
+        SHARED
+        ARCHS ${UBSAN_SUPPORTED_ARCH}
+        OBJECT_LIBS RTSanitizerCommon
+                RTSanitizerCommonLibc
+                RTUbsan
+                RTUbsan_cxx
+        CFLAGS ${UBSAN_CXXFLAGS}
+        LINK_FLAGS ${SANITIZER_COMMON_LINK_FLAGS}
+        LINK_LIBS ${UBSAN_DYNAMIC_LIBS}
+        PARENT_TARGET ubsan)
+
       set(ARCHS_FOR_SYMBOLS ${UBSAN_SUPPORTED_ARCH})
       list(REMOVE_ITEM ARCHS_FOR_SYMBOLS i386)
       add_sanitizer_rt_symbols(clang_rt.ubsan_standalone


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37884.115340.patch
Type: text/x-patch
Size: 1965 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170915/6eb9e045/attachment.bin>


More information about the llvm-commits mailing list