[PATCH] D37863: Fix bug 34608 by moving private header out of public header.WindowsManifestMerger.h should not include llvm/Config/config.h, since it is private. The include has been moved to the source instead.

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 16:00:54 PDT 2017


ecbeckmann marked an inline comment as done.
ecbeckmann added inline comments.


================
Comment at: llvm/lib/WindowsManifest/WindowsManifestMerger.cpp:16
 #include "llvm/Support/MemoryBuffer.h"
+#include "llvm/WindowsManifest/WindowsManifestMerger.h"
 
----------------
orivej wrote:
> Shouldn't the synonymous header be always the first include (to check that it is self-sufficient)?
right good point


https://reviews.llvm.org/D37863





More information about the llvm-commits mailing list