[PATCH] D37059: [ELF] - LTO: do not optimize away symbols accessed from linkerscript.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 11:24:03 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/LTO.cpp:168
       undefine(Sym);
-    R.LinkerRedefined = Config->RenamedSymbols.count(Sym);
+    // We tell LTO to not apply IPO for following symbols.
+    R.LinkerRedefined =
----------------
"following symbols" doesn't explain what this code is for. It's basically saying that this code does something as is written. Please update the comment.


https://reviews.llvm.org/D37059





More information about the llvm-commits mailing list