[PATCH] D37013: [ELF] - Add additional information about location when emiting linkerscript's parsing errors.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 10:58:38 PDT 2017


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added a comment.
>
> Yes, I understand that, but as I wrote in a previous comment, this kind of style
>
>   error: foo bar
>   >>> A
>   >>> B
>   >>> C
>
> is odd unless A, B and C are list items for the same list. In other words, you cannot always simply concatenate all error messages with ">>>\n".

Not sure I understand the distinction.

In any case, how about

.... expected, but got }
 >>> while parsing description for output section '.foo':

That is similar to what we do in other errors is that the second line
adds context showing where the error was found.

Cheers,
Rafael


More information about the llvm-commits mailing list