[PATCH] D37563: Convenience/safety fix for llvm::sys::Execute(And|No)Wait

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 14 09:28:34 PDT 2017


vsk added a comment.

In https://reviews.llvm.org/D37563#870647, @alexfh wrote:

> In https://reviews.llvm.org/D37563#865541, @vsk wrote:
>
> > It'd be nice to add in "expected 3 redirects" to the assert bodies.
>
>
> Sorry, missed this comment somehow. If we add a message, it should also cover the case of zero redirects. Something along the lines of "expected 0 or 3 redirects". I have a slight concern that the message would basically repeat the condition resulting in a sort of tautology (`assert((Redirects.empty() || Redirects.size() == 3) && "expected 0 or 3 redirects");`). But if you still find this useful, I can add a message.


I see, it looks fine as-is.


Repository:
  rL LLVM

https://reviews.llvm.org/D37563





More information about the llvm-commits mailing list