[PATCH] D37099: Added optional validation of svn sources to Dockerfiles.

[Ilya Biryukov via Phabricator via llvm-commits]

ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.


================
Comment at: utils/docker/scripts/llvm_checksum/llvm_checksum.py:86
+
+  def read_replacing_subsitutions(file_path):
+    with open(file_path, "rb") as f:
----------------
klimek wrote:
> Substitute subsitutions for substitutions.
Substituted with a name mentioning less substitutions.


================
Comment at: utils/docker/scripts/llvm_checksum/llvm_checksum.py:114
+      file_digest = hasher.hexdigest()
+      logging.debug("Checksum %s for file %s", file_digest, file_path)
+      files.append((file_path, file_digest))
----------------
klimek wrote:
> So the main reason we hash each file is for debugging purposes?
Yes, makes debugging when checksums don't match easier.

An alternative I was thinking about is to just feed all files to a single hasher, but that would probably allow to easily craft two different directory trees with the same hashes.


https://reviews.llvm.org/D37099