[PATCH] D35635: Optimize {s,u}{add,sub}.with.overflow on ARM

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 16:02:41 PDT 2017


efriedma added a comment.

I'm kind of waiting for https://reviews.llvm.org/D35192 to land here... unfortunately, it's been bouncing in and out of the tree due to regressions, but once it lands, I'd like to see what it does to our lowering here.

I think it might make more sense to wait until we have ARMISD::ADDC nodes in the DAG, then try to to optimize away the ARMISD::CMP nodes.  That way, you don't have to worry about trying to optimize away redundant instructions after SelectionDAG.


https://reviews.llvm.org/D35635





More information about the llvm-commits mailing list