[PATCH] D37698: Add target callback doMemOpsHaveSameBasePtr

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 13:57:55 PDT 2017


rampitec planned changes to this revision.
rampitec added a comment.

In https://reviews.llvm.org/D37698#870072, @MatzeB wrote:

> In https://reviews.llvm.org/D37698#869935, @rampitec wrote:
>
> > As an alternative I can just drop this portion of code from BaseMemOpClusterMutation::clusterNeighboringMemOps() completely:
> >
> >   if (MemOpRecords[Idx].BaseReg != MemOpRecords[Idx+1].BaseReg) {
> >     ClusterLength = 1;
> >     continue;
> >   }
> >   
> >
> > and let TII->shouldClusterMemOps() decide. Maybe it is better. Thoughts?
>
>
> Indeed, that sounds like the best/easiest solution so far!


I will do so then. Looks cleaner to me.


https://reviews.llvm.org/D37698





More information about the llvm-commits mailing list