[lld] r313187 - Do not use hasArgNoClaim().

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 13:30:59 PDT 2017


Author: ruiu
Date: Wed Sep 13 13:30:59 2017
New Revision: 313187

URL: http://llvm.org/viewvc/llvm-project?rev=313187&view=rev
Log:
Do not use hasArgNoClaim().

Arg instances can be claimed. After claimed, its `isClaimed` function
returns true. We do not use that notion in lld, so using NoClaim
versions of functions is just confusing. This patch is to just use
hasArg instead of hasArgNoClaim.

Modified:
    lld/trunk/COFF/Driver.cpp
    lld/trunk/MinGW/Driver.cpp

Modified: lld/trunk/COFF/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Driver.cpp?rev=313187&r1=313186&r2=313187&view=diff
==============================================================================
--- lld/trunk/COFF/Driver.cpp (original)
+++ lld/trunk/COFF/Driver.cpp Wed Sep 13 13:30:59 2017
@@ -744,8 +744,8 @@ void LinkerDriver::link(ArrayRef<const c
     }
   }
 
-  if (!Args.hasArgNoClaim(OPT_INPUT)) {
-    if (Args.hasArgNoClaim(OPT_deffile))
+  if (!Args.hasArg(OPT_INPUT)) {
+    if (Args.hasArg(OPT_deffile))
       Config->NoEntry = true;
     else
       fatal("no input files");
@@ -1067,7 +1067,7 @@ void LinkerDriver::link(ArrayRef<const c
   }
 
   // Handle generation of import library from a def file.
-  if (!Args.hasArgNoClaim(OPT_INPUT)) {
+  if (!Args.hasArg(OPT_INPUT)) {
     fixupExports();
     createImportLibrary(/*AsLib=*/true);
     exit(0);

Modified: lld/trunk/MinGW/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/MinGW/Driver.cpp?rev=313187&r1=313186&r2=313187&view=diff
==============================================================================
--- lld/trunk/MinGW/Driver.cpp (original)
+++ lld/trunk/MinGW/Driver.cpp Wed Sep 13 13:30:59 2017
@@ -76,7 +76,7 @@ opt::InputArgList MinGWOptTable::parse(A
     error(StringRef(Args.getArgString(MissingIndex)) + ": missing argument");
   for (auto *Arg : Args.filtered(OPT_UNKNOWN))
     error("unknown argument: " + Arg->getSpelling());
-  if (!Args.hasArgNoClaim(OPT_INPUT) && !Args.hasArgNoClaim(OPT_l))
+  if (!Args.hasArg(OPT_INPUT) && !Args.hasArg(OPT_l))
     error("no input files");
   return Args;
 }




More information about the llvm-commits mailing list