[PATCH] D36573: [ELF] - Treat .gnu.linkonce sections as COMDAT

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 12:10:51 PDT 2017


>I am not a fan of this change.
>
>Correct if I am wrong, but in all software that lld was ever tested in,
>only one case showed up: a single file in glibc. The only reason it
>shows up is because it is an old assembly file that has never been
>updated.
>
>Linkonce was an incomplete design and we really should push users to
>switch to comdats.
>
>Cheers,
>Rafael

Yep, and that is why this patch was abandoned about a month ago I believe :)

George.


More information about the llvm-commits mailing list