[PATCH] D37789: ThinLTO: Correctly follow aliasee references when dead stripping.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 09:55:33 PDT 2017


pcc added a comment.

In https://reviews.llvm.org/D37789#869660, @tejohnson wrote:

> LGTM, not sure how we didn't hit this before!
>
> Short of restructuring the class hierarchy so that AliasSummary doesn't have the refs member


Alternatively, represent alias summaries using a copy of the aliasee's FunctionSummary or GlobalVariableSummary, and remove the AliasSummary class altogether.

> I should at least remove that parameter from the constructor, and probably add an assert in the base class constructor that we don't have a non-empty list for an alias summary type. I'll go ahead and do that in a separate patch...

OK, sounds good.


https://reviews.llvm.org/D37789





More information about the llvm-commits mailing list