[PATCH] D37788: [ARM] builtins: Do not abort in clear_cache.

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Digging it a bit, commit r203674 (reviewed by dsanders/bastien) introduced this part for Android ARM/MIPS.

The original description indicates that the reasons for this patch were misguided, the bug report has nothing to indicate what the error was and why turning the error checking off would fix it.

We're down to just emulating libgcc bug-for-bug, and that's not a path I'm willing to blindly take.

So, I recommend the authors to dig a bit more of what's happening and come up with either a clear description of why the error handling needs removing, or submit a new patch to fix the actual problem.

@joerg From a system point of view, how common is the case where the parameters are garbage? Shouldn't systems validate them before calling a service call? If users/libraries are calling system calls with bad arguments, don't we want to know what, why and how to fix them?


https://reviews.llvm.org/D37788